Github user manishamde commented on the pull request:
https://github.com/apache/spark/pull/2780#issuecomment-59064525
@chouqin Good point. The sort operation is the bottleneck, not the value
count. It might be good to check numbers with a test run to verify whether the
performance hit is low.
In general, we should also think of using approximate histogramming algos
for speeding up this operation in the case of large number of maxBins. The N^2
minimum samples requirement was a conservative approximation based on Chernoff
bounds calculation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
