Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19783#discussion_r156281223
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/EstimationUtils.scala
 ---
    @@ -114,4 +114,99 @@ object EstimationUtils {
         }
       }
     
    +  /**
    +   * Returns the number of the first bin into which a column value falls 
for a specified
    +   * numeric equi-height histogram.
    +   *
    +   * @param value a literal value of a column
    +   * @param bins an array of bins for a given numeric equi-height histogram
    +   * @return the id of the first bin into which a column value falls.
    +   */
    +  def findFirstBinForValue(value: Double, bins: Array[HistogramBin]): Int 
= {
    +    var i = 0
    +    while ((i < bins.length) && (value > bins(i).hi)) {
    +      i += 1
    +    }
    +    i
    +  }
    +
    +  /**
    +   * Returns the number of the last bin into which a column value falls 
for a specified
    +   * numeric equi-height histogram.
    +   *
    +   * @param value a literal value of a column
    +   * @param bins an array of bins for a given numeric equi-height histogram
    +   * @return the id of the last bin into which a column value falls.
    +   */
    +  def findLastBinForValue(value: Double, bins: Array[HistogramBin]): Int = 
{
    +    var i = bins.length - 1
    +    while ((i >= 0) && (value < bins(i).lo)) {
    +      i -= 1
    +    }
    +    i
    +  }
    +
    +  /**
    +   * Returns a percentage of a bin holding values for column value in the 
range of
    +   * [lowerValue, higherValue]
    +   *
    +   * @param higherValue a given upper bound value of a specified column 
value range
    +   * @param lowerValue a given lower bound value of a specified column 
value range
    +   * @param bin a single histogram bin
    +   * @return the percentage of a single bin holding values in [lowerValue, 
higherValue].
    --- End diff --
    
    redundant


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to