Github user mgaido91 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19811#discussion_r156349126
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
 ---
    @@ -1179,6 +1257,18 @@ object CodeGenerator extends Logging {
       // class.
       val GENERATED_CLASS_SIZE_THRESHOLD = 1000000
     
    +  // This is the threshold for the number of global variables, whose types 
are primitive type or
    +  // complex type (e.g. more than one-dimensional array), that will be 
placed at the outer class
    +  val OUTER_CLASS_VARIABLES_THRESHOLD = 10000
    +
    +  // This is the maximum number of array elements to keep global variables 
in one Java array
    +  // 32767 is the maximum integer value that does not require a constant 
pool entry in a Java
    +  // bytecode instruction
    +  val MUTABLESTATEARRAY_SIZE_LIMIT = 32768
    +
    +  // This is an index variable name used in a loop for initializing global 
variables
    +  val INIT_LOOP_VARIABLE_NAME = "i"
    --- End diff --
    
    this is not needed anymore IMHO


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to