Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19946#discussion_r156352778
--- Diff: sbin/build-push-docker-images.sh ---
@@ -0,0 +1,67 @@
+#!/usr/bin/env bash
+
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+# This script builds and pushes docker images when run from a release of
Spark
+# with Kubernetes support.
+
+declare -A path=( [spark-driver]=dockerfiles/driver/Dockerfile \
+ [spark-executor]=dockerfiles/executor/Dockerfile )
+
+function build {
+ docker build -t spark-base -f dockerfiles/spark-base/Dockerfile .
+ for image in "${!path[@]}"; do
+ docker build -t ${REPO}/$image:${TAG} -f ${path[$image]} .
+ done
+}
+
+
+function push {
+ for image in "${!path[@]}"; do
+ docker push ${REPO}/$image:${TAG}
+ done
+}
+
+function usage {
--- End diff --
So likely not for this PR, but I'm wondering for the future what you think
about the idea of extending this to package up a usable Python env so we can
solve the dependency management issue as well?
Really excited to see the progress :)
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
