Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19932#discussion_r156396524
  
    --- Diff: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala 
---
    @@ -1011,6 +986,8 @@ private[hive] object HiveClientImpl {
        */
       def fromHivePartition(hp: HivePartition): CatalogTablePartition = {
         val apiPartition = hp.getTPartition
    +    val properties: Map[String, String] =
    +      if (hp.getParameters != null) hp.getParameters.asScala.toMap else 
Map.empty
    --- End diff --
    
    nit: if can't fit in one line, prefer
    ```
    val xxx = if {
      ...
    } else {
      ...
    }
    ```


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to