Github user CodingCat commented on a diff in the pull request:
https://github.com/apache/spark/pull/19926#discussion_r156451756
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala
---
@@ -71,27 +68,29 @@ class StreamExecution(
import org.apache.spark.sql.streaming.StreamingQueryListener._
- private val pollingDelayMs =
sparkSession.sessionState.conf.streamingPollingDelay
+ protected val pollingDelayMs: Long =
sparkSession.sessionState.conf.streamingPollingDelay
- private val minBatchesToRetain =
sparkSession.sessionState.conf.minBatchesToRetain
+ protected val minBatchesToRetain: Int =
sparkSession.sessionState.conf.minBatchesToRetain
require(minBatchesToRetain > 0, "minBatchesToRetain has to be positive")
/**
* A lock used to wait/notify when batches complete. Use a fair lock to
avoid thread starvation.
*/
- private val awaitBatchLock = new ReentrantLock(true)
- private val awaitBatchLockCondition = awaitBatchLock.newCondition()
+ protected val awaitProgressLock = new ReentrantLock(true)
+ protected val awaitProgressLockCondition: Condition =
awaitProgressLock.newCondition()
private val initializationLatch = new CountDownLatch(1)
private val startLatch = new CountDownLatch(1)
private val terminationLatch = new CountDownLatch(1)
- val resolvedCheckpointRoot = {
+ val resolvedCheckpointRoot: String = {
--- End diff --
I think it's easy for the reader to derive that it is a String-typed
variable from the code
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
