Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2760#discussion_r18854282
  
    --- Diff: core/src/main/scala/org/apache/spark/api/java/JavaRDDLike.scala 
---
    @@ -575,16 +574,49 @@ trait JavaRDDLike[T, This <: JavaRDDLike[T, This]] 
extends Serializable {
       def name(): String = rdd.name
     
       /**
    -   * :: Experimental ::
    -   * The asynchronous version of the foreach action.
    -   *
    -   * @param f the function to apply to all the elements of the RDD
    -   * @return a FutureAction for the action
    +   * The asynchronous version of `count`, which returns a
    +   * future for counting the number of elements in this RDD.
        */
    -  @Experimental
    -  def foreachAsync(f: VoidFunction[T]): FutureAction[Unit] = {
    +  def countAsync(): JavaFutureAction[JLong] = {
    +    import org.apache.spark.SparkContext._
    +    new JavaFutureActionWrapper[Long, JLong](rdd.countAsync(), x => new 
JLong(x))
    +  }
    +
    +  /**
    +   * The asynchronous version of `collect`, which returns a future for
    +   * retrieving an array containing all of the elements in this RDD.
    +   */
    +  def collectAsync(): JavaFutureAction[JList[T]] = {
    +    import org.apache.spark.SparkContext._
    +    new JavaFutureActionWrapper(rdd.collectAsync(), (x: Seq[T]) => new 
java.util.ArrayList(x))
    --- End diff --
    
    I wonder if `x.asJava` would be more efficient by avoiding the copy.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to