Github user mgaido91 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19964#discussion_r156675619
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
 ---
    @@ -289,53 +289,56 @@ case class Elt(children: Seq[Expression])
         val index = indexExpr.genCode(ctx)
         val strings = stringExprs.map(_.genCode(ctx))
         val indexVal = ctx.freshName("index")
    +    val resultState = ctx.freshName("eltResultState")
    --- End diff --
    
    maybe this can have a better name now that it is a boolean.... I am not 
very good at naming, but something like `indexFound` or anything you feel 
appropriate...


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to