Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19969#discussion_r156729203
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala
---
@@ -192,7 +192,7 @@ case class BroadcastHashJoinExec(
| $value = ${ev.value};
|}
""".stripMargin
- ExprCode(code, isNull, value)
+ ExprCode(code, isNull, value, inputRow = matched)
--- End diff --
I checked if the files below have the same issue though, I didn't found it
(double-checks needed);
```
./catalyst/expressions/codegen/CodeGenerator.scala:202: ExprCode(code,
"false", value)
./catalyst/expressions/codegen/ExpressionCodegen.scala:89:
ExprCode(code = "", value = state.value, isNull = state.isNull)
./catalyst/expressions/codegen/GenerateMutableProjection.scala:90:
val ev = ExprCode("", s"isNull_$i", s"value_$i")
./catalyst/expressions/codegen/GenerateSafeProjection.scala:77:
ExprCode(code, "false", output)
./catalyst/expressions/codegen/GenerateSafeProjection.scala:107:
ExprCode(code, "false", output)
./catalyst/expressions/codegen/GenerateSafeProjection.scala:128:
ExprCode(code, "false", output)
./catalyst/expressions/codegen/GenerateSafeProjection.scala:140: case _
=> ExprCode("", "false", input)
./catalyst/expressions/codegen/GenerateUnsafeProjection.scala:55:
ExprCode("", s"$tmpInput.isNullAt($i)", ctx.getValue(tmpInput, dt, i.toString))
./catalyst/expressions/codegen/GenerateUnsafeProjection.scala:353:
ExprCode(code, "false", result)
./catalyst/expressions/complexTypeCreator.scala:397: ExprCode(code =
eval.code, isNull = "false", value = eval.value)
./catalyst/expressions/datetimeExpressions.scala:677: ExprCode("",
"true", ctx.defaultValue(dataType))
./catalyst/expressions/datetimeExpressions.scala:812: ExprCode("",
"true", "(UTF8String) null")
./catalyst/expressions/Expression.scala:103:
ExprCode(ctx.registerComment(this.toString), subExprState.isNull,
subExprState.value)
./catalyst/expressions/Expression.scala:107: val eval = doGenCode(ctx,
ExprCode("", isNull, value))
./catalyst/expressions/misc.scala:85: ExprCode(code = s"""${eval.code}
./catalyst/expressions/nullExpressions.scala:325: ExprCode(code =
eval.code, isNull = "false", value = eval.isNull)
./catalyst/expressions/nullExpressions.scala:351: ExprCode(code =
eval.code, isNull = "false", value = s"(!(${eval.isNull}))")
./catalyst/expressions/objects/objects.scala:448: ExprCode(code = "",
value = value, isNull = if (nullable) isNull else "false")
./execution/aggregate/HashAggregateExec.scala:200: ExprCode(ev.code +
initVars, isNull, value)
./execution/aggregate/HashMapGenerator.scala:59: ExprCode(ev.code +
initVars, isNull, value)
./execution/basicPhysicalOperators.scala:372: val ev = ExprCode("",
"false", value)
./execution/ColumnarBatchScan.scala:62: ExprCode(code, isNullVar,
valueVar)
./execution/ExpandExec.scala:159: ExprCode(code, isNull, value)
./execution/GenerateExec.scala:172: Seq(ExprCode("", s"$index ==
-1", index))
./execution/GenerateExec.scala:174: Seq(ExprCode("", "false", index))
./execution/GenerateExec.scala:317: ExprCode(code, isNull, value)
./execution/GenerateExec.scala:319: ExprCode(s"$javaType $value =
$getter;", "false", value)
./execution/joins/BroadcastHashJoinExec.scala:195: ExprCode(code,
isNull, value, inputRow = matched)
./execution/joins/BroadcastHashJoinExec.scala:490: val resultVar = input
++ Seq(ExprCode("", "false", existsVar))
./execution/joins/SortMergeJoinExec.scala:535: (ExprCode(code,
isNull, value), leftVarsDecl)
./execution/joins/SortMergeJoinExec.scala:539: (ExprCode(code,
"false", value), leftVarsDecl)
./execution/WholeStageCodegenExec.scala:130: ExprCode("", "false", row)
./execution/WholeStageCodegenExec.scala:145: ExprCode(code, "false",
ev.value)
./execution/WholeStageCodegenExec.scala:148: ExprCode("", "false",
"unsafeRow")
```
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
