Github user aokolnychyi commented on the issue:

    https://github.com/apache/spark/pull/18692
  
    Sure, if you guys think it does not give any performance benefits, then 
let's revert it.
    
    I also had similar concerns but my understanding was that having an inner 
join with some equality condition can be beneficial during the generation of a 
physical plan. In other words, Spark should be able to select a more efficient 
join implementation. I am not sure how it is right now but previously you could 
have only ``BroadcastNestedLoopJoin`` or ``CartesianProduct`` without any 
equality condition. Again, that was my assumption based on what I remember. 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to