Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2696#discussion_r18863321
  
    --- Diff: 
core/src/main/scala/org/apache/spark/api/java/JavaSparkContext.scala ---
    @@ -132,6 +132,12 @@ class JavaSparkContext(val sc: SparkContext)
       /** Default min number of partitions for Hadoop RDDs when not given by 
user */
       def defaultMinPartitions: java.lang.Integer = sc.defaultMinPartitions
     
    +  def getJobsIdsForGroup(jobGroup: String): Array[Int] = 
sc.getJobsIdsForGroup(jobGroup)
    +
    +  def getJobInfo(jobId: Int): SparkJobInfo = sc.getJobInfo(jobId).orNull
    --- End diff --
    
    I suppose that I could use a Guava `Optional` here, although we were bitten 
in the past by exposing this third-party type in our APIs.  Returning `null` 
would be inconsistent with the use of `Optional` in other parts of the Java API 
(such as `JavaSparkContext.getCheckpointDir()`).  On the other hand, we may be 
stuck with `Optional` since other code exposes it.
    
    What do you think we should do here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to