Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19811#discussion_r156923234
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateMutableProjection.scala
---
@@ -57,41 +57,35 @@ object GenerateMutableProjection extends
CodeGenerator[Seq[Expression], MutableP
case _ => true
}.unzip
val exprVals = ctx.generateExpressions(validExpr,
useSubexprElimination)
- val projectionCodes = exprVals.zip(index).map {
+ val projectionCodes: Seq[(String, String, String, Int)] =
exprVals.zip(index).map {
--- End diff --
add a comment to explain this tuple-4
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
