Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19811#discussion_r156928231
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala 
---
    @@ -110,8 +110,8 @@ case class RowDataSourceScanExec(
       override protected def doProduce(ctx: CodegenContext): String = {
         val numOutputRows = metricTerm(ctx, "numOutputRows")
         // PhysicalRDD always just has one input
    -    val input = ctx.freshName("input")
    -    ctx.addMutableState("scala.collection.Iterator", input, s"$input = 
inputs[0];")
    +    val input = ctx.addMutableState("scala.collection.Iterator", "input", 
v => s"$v = inputs[0];",
    +      forceInline = true)
    --- End diff --
    
    why inline


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to