[GitHub] spark pull request #19941: [SPARK-22753][SQL] Get rid of dataSource.writeAnd...

[xuanyuanking]

Github user xuanyuanking commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19941#discussion_r156958793
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/command/InsertIntoDataSourceDirCommand.scala
 ---
    @@ -67,8 +67,9 @@ case class InsertIntoDataSourceDirCommand(
     
         val saveMode = if (overwrite) SaveMode.Overwrite else 
SaveMode.ErrorIfExists
         try {
    -      
sparkSession.sessionState.executePlan(dataSource.planForWriting(saveMode, 
query))
    -      dataSource.writeAndRead(saveMode, query)
    --- End diff --
    
    You're right, test the query "INSERT OVERWRITE DIRECTORY 
'/home/liyuanjian/tmp' USING json SELECT 1 AS a, 'c' as b;".
    
![image](https://user-images.githubusercontent.com/4833765/33997144-6d159446-e11e-11e7-8bae-f485873d84c3.png)


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org