Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19811#discussion_r157109584
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -189,15 +255,37 @@ class CodegenContext {
def declareMutableStates(): String = {
// It's possible that we add same mutable state twice, e.g. the
`mergeExpressions` in
// `TypedAggregateExpression`, we should call `distinct` here to
remove the duplicated ones.
- mutableStates.distinct.map { case (javaType, variableName, _) =>
+ val inlinedStates = inlinedMutableStates.distinct.map { case
(javaType, variableName) =>
s"private $javaType $variableName;"
- }.mkString("\n")
+ }
+
+ val arrayStates = arrayCompactedMutableStates.flatMap { case
(javaType, mutableStateArrays) =>
--- End diff --
Is it possible that we add same mutable state to
`arrayCompactedMutableStates` like `inlinedMutableStates`? We can't just do
distinct like `inlinedMutableStates`.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
