Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r157122909
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -50,15 +51,23 @@ import org.apache.spark.unsafe.types.{ByteArray,
UTF8String}
""")
case class Concat(children: Seq[Expression]) extends Expression with
ImplicitCastInputTypes {
- override def inputTypes: Seq[AbstractDataType] =
Seq.fill(children.size)(StringType)
- override def dataType: DataType = StringType
+ private lazy val isBinaryMode = children.nonEmpty &&
children.forall(_.dataType == BinaryType)
+
+ override def inputTypes: Seq[AbstractDataType] =
+ Seq.fill(children.size)(if (isBinaryMode) BinaryType else StringType)
+ override def dataType: DataType = if (isBinaryMode) BinaryType else
StringType
--- End diff --
Is it ok to add a new option for this case only? If we keep adding new
options for each case, options could blow up?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
