Github user viirya commented on the issue:

    https://github.com/apache/spark/pull/19813
  
    I'm wondering if an output statement like `a + 1` is a problem.
    
    If we only include codegen output with valid java variable names, an output 
like `a + 1` won't be included as parameter. We only need to make sure the 
creation of `ExprCode` in `genCode` has correctly linked with its input row and 
variables (this is done in this PR). So an output like `a + 1` depends on other 
input `a`. This `a` will be included as parameter if necessary.
    
    cc @cloud-fan @kiszk @mgaido91 WDYT? Or do I miss something?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to