Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19681#discussion_r157278467
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/ui/SQLListenerSuite.scala
 ---
    @@ -36,13 +36,14 @@ import org.apache.spark.sql.catalyst.util.quietly
     import org.apache.spark.sql.execution.{LeafExecNode, QueryExecution, 
SparkPlanInfo, SQLExecution}
     import org.apache.spark.sql.execution.metric.{SQLMetric, SQLMetrics}
     import org.apache.spark.sql.test.SharedSQLContext
    -import org.apache.spark.ui.SparkUI
    +import org.apache.spark.status.config._
     import org.apache.spark.util.{AccumulatorMetadata, JsonProtocol, 
LongAccumulator}
    -
    +import org.apache.spark.util.kvstore.InMemoryStore
     
     class SQLListenerSuite extends SparkFunSuite with SharedSQLContext with 
JsonTestUtils {
       import testImplicits._
    -  import org.apache.spark.AccumulatorSuite.makeInfo
    +
    +  override protected def sparkConf = 
super.sparkConf.set(LIVE_ENTITY_UPDATE_PERIOD, 0L)
    --- End diff --
    
    Is that true? The suite extends `SharedSQLContext` (which extends 
`SharedSparkSession`) and `SQLTestUtils`, all of which are traits, not objects. 
(Unlike `TestHive` which does force sessions to be used across suites for hive 
tests.)
    
    There are also other suites that modify the conf (such as 
`HDFSMetadataLogSuite`).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to