GitHub user HyukjinKwon opened a pull request:

    https://github.com/apache/spark/pull/20003

    [WIP][SPARK-22817][R] Use fixed testthat version for SparkR tests in 
AppVeyor

    ## What changes were proposed in this pull request?
    
    `testthat` 2.0.0 is released and AppVeyor now started to use it instead of 
1.0.2. And then, we started to have R tests failed in AppVeyor. See - 
https://ci.appveyor.com/project/ApacheSoftwareFoundation/spark/build/1967-master
    
    ```
    Error in get(name, envir = asNamespace(pkg), inherits = FALSE) : 
      object 'run_tests' not found
    Calls: ::: -> get
    ```
    
    This seems because we rely on internal `testthat:::run_tests` here:
    
    https://github.com/r-lib/testthat/blob/v1.0.2/R/test-package.R#L62-L75
    
    
https://github.com/apache/spark/blob/dc4c351837879dab26ad8fb471dc51c06832a9e4/R/pkg/tests/run-all.R#L49-L52
    
    However, seems it was removed out from 2.0.0.  I tried few other exposed 
APIs like `test_dir` but I failed to make a good compatible fix.
    
    Seems we better fix the `testthat` version first to make the build passed.
    
    
    ## How was this patch tested?
    
    Manually tested and AppVeyor tests.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/HyukjinKwon/spark SPARK-22817

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/20003.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #20003
    
----
commit 887cfe8ad84d16bb5304012065b8a72e9d6b73b0
Author: hyukjinkwon <[email protected]>
Date:   2017-12-16T15:48:52Z

    Use fixed testthat version for SparkR tests in AppVeyor

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to