Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19954#discussion_r157442475
--- Diff:
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/submit/DriverConfigOrchestratorSuite.scala
---
@@ -72,9 +76,57 @@ class DriverConfigurationStepsOrchestratorSuite extends
SparkFunSuite {
)
}
+ test("Submission steps with an init-container.") {
+ val sparkConf = new SparkConf(false)
+ .set(DRIVER_DOCKER_IMAGE, DRIVER_IMAGE)
+ .set(INIT_CONTAINER_IMAGE, IC_IMAGE)
+ .set("spark.jars", "hdfs://localhost:9000/var/apps/jars/jar1.jar")
+ val mainAppResource =
JavaMainAppResource("local:///var/apps/jars/main.jar")
+ val orchestrator = new DriverConfigOrchestrator(
+ NAMESPACE,
+ APP_ID,
+ LAUNCH_TIME,
+ Some(mainAppResource),
+ APP_NAME,
+ MAIN_CLASS,
+ APP_ARGS,
+ sparkConf)
+ validateStepTypes(
+ orchestrator,
+ classOf[BaseDriverConfigurationStep],
+ classOf[DriverServiceBootstrapStep],
+ classOf[DriverKubernetesCredentialsStep],
+ classOf[DependencyResolutionStep],
+ classOf[DriverInitContainerBootstrapStep])
+ }
+
+ test("Submission steps with driver secrets to mount") {
+ val sparkConf = new SparkConf(false)
+ .set(DRIVER_DOCKER_IMAGE, DRIVER_IMAGE)
+ .set(s"$KUBERNETES_DRIVER_SECRETS_PREFIX$SECRET_FOO",
SECRET_MOUNT_PATH)
+ .set(s"$KUBERNETES_DRIVER_SECRETS_PREFIX$SECRET_BAR",
SECRET_MOUNT_PATH)
+ val mainAppResource =
JavaMainAppResource("local:///var/apps/jars/main.jar")
+ val orchestrator = new DriverConfigOrchestrator(
+ NAMESPACE,
+ APP_ID,
+ LAUNCH_TIME,
+ Some(mainAppResource),
+ APP_NAME,
+ MAIN_CLASS,
+ APP_ARGS,
+ sparkConf)
+ validateStepTypes(
+ orchestrator,
+ classOf[BaseDriverConfigurationStep],
+ classOf[DriverServiceBootstrapStep],
+ classOf[DriverKubernetesCredentialsStep],
+ classOf[DependencyResolutionStep],
+ classOf[DriverMountSecretsStep])
+ }
+
private def validateStepTypes(
- orchestrator: DriverConfigurationStepsOrchestrator,
- types: Class[_ <: DriverConfigurationStep]*): Unit = {
+ orchestrator: DriverConfigOrchestrator,
+ types: Class[_ <:
DriverConfigurationStep]*): Unit = {
--- End diff --
nit: indent
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
