Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19981#discussion_r157585557
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/ui/SQLAppStatusListenerSuite.scala
 ---
    @@ -517,9 +516,12 @@ class SQLListenerMemoryLeakSuite extends SparkFunSuite 
{
               }
             }
             sc.listenerBus.waitUntilEmpty(10000)
    -
    -        val statusStore = new SQLAppStatusStore(sc.statusStore.store)
    -        assert(statusStore.executionsList().size <= 50)
    +        val statusStore = spark.sharedState.statusStore
    +        assert(statusStore.executionsCount() == 200)
    --- End diff --
    
    This is now wrong, isn't it? The configuration explicitly says "50". Since 
this test is not being run, you should leave the code as before (with just 
needed changes, if any, for it to compile).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to