Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/19968#discussion_r157631169
--- Diff: core/src/main/scala/org/apache/spark/rpc/netty/Dispatcher.scala
---
@@ -100,6 +102,7 @@ private[netty] class Dispatcher(nettyEnv: NettyRpcEnv,
numUsableCores: Int) exte
return
}
unregisterRpcEndpoint(rpcEndpointRef.name)
+ endpointsIsStopped.putIfAbsent(rpcEndpointRef.name, true)
--- End diff --
this will be a memory leak. Spark may create some temp RpcEndpoints. You
can make `postMessage` return `Some(RpcEndpointNotFoundException)` and ignore
it.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
