Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/19884#discussion_r157683878
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/python/ArrowPythonRunner.scala
---
@@ -126,18 +121,14 @@ class ArrowPythonRunner(
private var schema: StructType = _
private var vectors: Array[ColumnVector] = _
- private var closed = false
-
context.addTaskCompletionListener { _ =>
// todo: we need something like `reader.end()`, which release all
the resources, but leave
--- End diff --
@ueshin is this still a valid todo? It is possible in Arrow now by calling
`reader.close(false)` where the `false` flag will free resources but keep the
stream open.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
