Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/2746#discussion_r18922282
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
@@ -110,19 +110,26 @@ private[spark] class TaskSetManager(
// the one that it was launched from, but gets removed from them later.
private val pendingTasksForExecutor = new HashMap[String,
ArrayBuffer[Int]]
- // Set of pending tasks for each host. Similar to
pendingTasksForExecutor,
+ // List of pending tasks for each host. Similar to
pendingTasksForExecutor,
// but at host level.
private val pendingTasksForHost = new HashMap[String, ArrayBuffer[Int]]
- // Set of pending tasks for each rack -- similar to the above.
+ // List of pending tasks for each rack -- similar to the above.
private val pendingTasksForRack = new HashMap[String, ArrayBuffer[Int]]
- // Set containing pending tasks with no locality preferences.
+ // List of pending tasks with no locality preferences.
var pendingTasksWithNoPrefs = new ArrayBuffer[Int]
- // Set containing all pending tasks (also used as a stack, as above).
+ // List of all pending tasks (also used as a stack, as above).
val allPendingTasks = new ArrayBuffer[Int]
+ // Set of pending tasks used to keep track of whether more executors are
needed
--- End diff --
Describe how this is different than allPendingTasks in the comment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
