Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20017#discussion_r157757018
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/mllib/clustering/BisectingKMeans.scala ---
    @@ -212,7 +212,9 @@ class BisectingKMeans private (
           }
           level += 1
         }
    -    if(indices != null) indices.unpersist()
    +    if (preIndices != null) preIndices.unpersist(blocking = false)
    --- End diff --
    
    Do we usually write "blocking ="? there's only one argument.
    I'd use braces and put the body on the next line too.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to