Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20015
SPARK-17174 originally described few functions related with hour, min, etc.
but I received an advice to fix up other related functions too even though they
could also be done alone too. I agreed with doing other functions too at that
time and I tried to propose as so.
I am saying I think this PR actually more targets adding another (better)
version of `trunc` to support day, hour, min, etc. in the format. In this case,
I think we should deduplicate the logics with related functions too.
Ah, so, I think I am less sure about why this should be done alone leaving
out other related changes, and other functions we (I) usually reject.
and I think you and @cloud-fan say the reasons are, it's common and this PR
targets a separate functionality consistent with other DBMS.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
