Github user kiszk commented on the issue:

    https://github.com/apache/spark/pull/20021
  
    Here is [a fix](https://github.com/apache/spark/pull/19937) that avoids to 
pass a global variable to `ctx.splitExpressions`. Before this PR, [this 
error](https://github.com/apache/spark/pull/19865#issuecomment-348777024) 
occurs. I understand that my fix is not localization, but one of approaches 
does not pass a global variable to successor steps like localization. My lesson 
learned is to pass a global variable accidentally happens thru deep call stack.
    
    Would it be possible to share finding from your manual check at all the 
caller side of `ctx.splitExpressions`. Why can we ensure any global variables 
are not passed to `ctx.splitExpressions`? I think that it would be good to put 
the rational into the comment.



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to