Github user mgaido91 commented on the issue:

    https://github.com/apache/spark/pull/19993
  
    @hhbyyh thanks for the comments. I already fixed all your comments, but I 
am waiting to push for the UT. Honestly I think that `checkParam` is not the 
best place. Checking the exception requires setting the parameters and invoking 
`transform`, thus I am not sure it is the best place, since it is a very 
generic one and at the moment we are setting no parameter there. What do you 
think?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to