Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20015#discussion_r157896273
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
 ---
    @@ -964,7 +981,62 @@ object DateTimeUtils {
       }
     
       /**
    -   * Returns the truncate level, could be TRUNC_YEAR, TRUNC_MONTH, or 
TRUNC_INVALID,
    +   * Returns the trunc date time from original date time and trunc level.
    +   * Trunc level should be generated using `parseTruncLevel()`, should be 
between 1 and 8
    +   */
    +  def truncTimestamp(d: SQLTimestamp, level: Int, timeZone: TimeZone): 
SQLTimestamp = {
    --- End diff --
    
    nit: d -> ts or t


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to