Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20021#discussion_r157915518
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -930,6 +930,18 @@ class CodegenContext {
// inline execution if only one block
blocks.head
} else {
+ if (Utils.isTesting) {
--- End diff --
Do we only do the assert in testing? Because passing global variables won't
raise compile error, if we have any global variables passed in when not in
testing, the codegen still work and may lead to wrong result.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
