Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r157940901
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -566,6 +568,21 @@ object TypeCoercion {
}
}
+ /**
+ * When all inputs in [[Concat]] are binary, coerces an output type to
binary
+ */
+ case class ConcatCoercion(conf: SQLConf) extends TypeCoercionRule {
--- End diff --
I feel this rule is a little hacky as it must be run before
`ImplicitTypeCasts`. I think we should not make `Concat` extends
`ImplicitCastInputTypes`, and do type coercion manually for it with a customer
rule.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
