GitHub user Ngone51 opened a pull request:

    https://github.com/apache/spark/pull/20033

    [SPARK-22847] [CORE] Remove duplicate code in AppStatusListener while 
assigning schedulingPool for stage 

    ## What changes were proposed in this pull request?
    
    In AppStatusListener's onStageSubmitted(event: SparkListenerStageSubmitted) 
method, there are duplicate code:
    ```
    // schedulingPool was assigned twice with the same code
    stage.schedulingPool = Option(event.properties).flatMap { p =>
          Option(p.getProperty("spark.scheduler.pool"))
        }.getOrElse(SparkUI.DEFAULT_POOL_NAME)
    ```
    But, it does not make any sense to do this and there are no comment to 
explain for this.
    
    ## How was this patch tested?
    N/A

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Ngone51/spark dev-spark-22847

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/20033.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #20033
    
----
commit ace04a5c75a0dc46e0575677be6be77ab6b58895
Author: wuyi <ngone_5451@...>
Date:   2017-12-20T13:03:49Z

    remove duplicate code in AppStatusListener while assigning schedulingPool 
for stage

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to