Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/20020#discussion_r158219553
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -87,6 +87,51 @@ case class ExecutedCommandExec(cmd: RunnableCommand)
extends LeafExecNode {
}
}
--- End diff --
Well, I prefer to keep it. It is used only in `ExecutedCommandExec`, and in
the future if there are new `RunnableCommand` with metrics, the new command can
just override `metrics`.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]