GitHub user smurakozi opened a pull request:

    https://github.com/apache/spark/pull/20045

    [Spark-22360][SQL] Add unit tests for Window Specifications

    ## What changes were proposed in this pull request?
    
    Improve the test coverage of window specifications.
    
    New tests cover basic cases more systematically in 
DataFrameWindowFunctionsSuite:
    - different partition clauses (none, one, multiple)
    - different order clauses (none, one, multiple, asc/desc, nulls first/last)
    - defaults if clauses are missing
    
    New tests were added to cover some more complex cases when partitionBy or 
orderBy uses expressions.
    
    ExpressionParserSuite.'window function expressions' was also extended to 
check parsing of some additional window expressions.
    
    ## How was this patch tested?
    Only new tests were added, automated tests were executed.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/smurakozi/spark SPARK-22360

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/20045.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #20045
    
----
commit 313aafbebc134ec02110a31fb99bb72c30d61639
Author: Sandor Murakozi <smurakozi@...>
Date:   2017-12-21T11:23:12Z

    New test cases for window specification

commit 6c48095358aa77d3dd12c7dbba97ecc31c22604e
Author: Sandor Murakozi <smurakozi@...>
Date:   2017-12-21T13:05:02Z

    test for filtering based on window function

commit e941aca540c68e74c80d279150c8d8731f2ed332
Author: Sandor Murakozi <smurakozi@...>
Date:   2017-12-21T13:47:11Z

    More test expressions in ExpressionParserSuite.window function expressions

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to