Github user kiszk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20043#discussion_r158299743
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/nullExpressions.scala
 ---
    @@ -347,7 +353,14 @@ case class IsNotNull(child: Expression) extends 
UnaryExpression with Predicate {
     
       override def doGenCode(ctx: CodegenContext, ev: ExprCode): ExprCode = {
         val eval = child.genCode(ctx)
    -    ExprCode(code = eval.code, isNull = "false", value = 
s"(!(${eval.isNull}))")
    +    val value = if ("true" == s"${eval.isNull}") {
    --- End diff --
    
    ditto


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to