Github user Ngone51 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20039#discussion_r158424923
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/LiveListenerBus.scala ---
@@ -149,7 +158,11 @@ private[spark] class LiveListenerBus(conf: SparkConf) {
}
this.sparkContext = sc
- queues.asScala.foreach(_.start(sc))
+ queues.asScala.foreach { q =>
+ q.start(sc)
+ queuedEvents.foreach(q.post)
--- End diff --
```
q.start(sc)
queuedEvents.foreach(q.post)
```
Ummm... In my opinion, exchange these two lines sequence would be better
for following the original logic of events buffered before a queue calls
start(). So, queuedEvents post to queues first before queues start would be
unified logically.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
