Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20036#discussion_r158439773
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala
---
@@ -118,9 +118,8 @@ case class Like(left: Expression, right: Expression)
extends StringRegexExpressi
if (rVal != null) {
val regexStr =
StringEscapeUtils.escapeJava(escape(rVal.asInstanceOf[UTF8String].toString()))
- // inline mutable state since not many Like operations in a task
val pattern = ctx.addMutableState(patternClass, "patternLike",
- v => s"""$v = ${patternClass}.compile("$regexStr");""",
forceInline = true)
+ v => s"""$v = ${patternClass}.compile("$regexStr");""")
--- End diff --
Sure, done for other places, too.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
