Github user fjh100456 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19218#discussion_r158458747
  
    --- Diff: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveOptions.scala 
---
    @@ -102,4 +111,18 @@ object HiveOptions {
         "collectionDelim" -> "colelction.delim",
         "mapkeyDelim" -> "mapkey.delim",
         "lineDelim" -> "line.delim").map { case (k, v) => 
k.toLowerCase(Locale.ROOT) -> v }
    +
    +  def getHiveWriteCompression(tableInfo: TableDesc, sqlConf: SQLConf): 
Option[(String, String)] = {
    +    tableInfo.getOutputFileFormatClassName.toLowerCase match {
    +      case formatName if formatName.endsWith("parquetoutputformat") =>
    +        val compressionCodec = new 
ParquetOptions(tableInfo.getProperties.asScala.toMap,
    +          sqlConf).compressionCodecClassName
    --- End diff --
    
    Yes it looke better, I will change it.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to