Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20031#discussion_r158481310
  
    --- Diff: R/pkg/R/functions.R ---
    @@ -40,10 +40,17 @@ NULL
     #'
     #' @param x Column to compute on. In \code{window}, it must be a time 
Column of
     #'          \code{TimestampType}.
    -#' @param format For \code{to_date} and \code{to_timestamp}, it is the 
string to use to parse
    -#'               Column \code{x} to DateType or TimestampType. For 
\code{trunc}, it is the string
    -#'               to use to specify the truncation method. For example, 
"year", "yyyy", "yy" for
    -#'               truncate by year, or "month", "mon", "mm" for truncate by 
month.
    +#' @param format The format for the given dates or timestamps in Column 
\code{x}. See the
    +#'               format used in the following methods:
    +#'               \itemize{
    +#'               \item \code{to_date} and \code{to_timestamp}: it is the 
string to use to parse
    +#'                    Column \code{x} to DateType or TimestampType.
    +#'               \item \code{trunc}: it is the string to use to specify 
the truncation method.
    +#'                    For example, "year", "yyyy", "yy" for truncate by 
year, or "month", "mon",
    +#'                    "mm" for truncate by month.
    +#'               \item \code{date_trunc}: it is similar with 
\code{trunc}'s but additionally
    +#'                    supports "day", "dd", "second", "minute", "hour", 
"week" and "quarter".
    +#'               }
    --- End diff --
    
    I am fine with a single paragraph too. Please let me know if you have a 
preference @felixcheung. 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to