Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20053#discussion_r158520709
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/AsyncEventQueue.scala ---
@@ -112,6 +112,7 @@ private class AsyncEventQueue(val name: String, conf:
SparkConf, metrics: LiveLi
private[scheduler] def start(sc: SparkContext): Unit = {
if (started.compareAndSet(false, true)) {
this.sc = sc
+ lastReportTimestamp = System.currentTimeMillis()
--- End diff --
According to the description of `lastReportTimestamp`:
```
/** When `droppedEventsCounter` was logged last time in milliseconds. */
```
It seems not very sound to update the val on `start()`.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
