Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/2826#discussion_r18964919
--- Diff:
core/src/main/scala/org/apache/spark/storage/DiskBlockManager.scala ---
@@ -140,7 +140,6 @@ private[spark] class DiskBlockManager(blockManager:
BlockManager, conf: SparkCon
}
private def addShutdownHook() {
- localDirs.foreach(localDir =>
Utils.registerShutdownDeleteDir(localDir))
--- End diff --
It seems undesirable to duplicate the delete logic but I can see that stop
needs to trigger a delete. What exception happens ? Deleting something that
isn't there should not be an erro .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
