Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2739#discussion_r18975328
  
    --- Diff: core/src/main/scala/org/apache/spark/SecurityManager.scala ---
    @@ -192,6 +196,44 @@ private[spark] class SecurityManager(sparkConf: 
SparkConf) extends Logging {
         )
       }
     
    +  private[spark] val sslOptions = SSLOptions.parse(ns = "ssl", conf = 
sparkConf)
    --- End diff --
    
    You declared the parameters in the opposite order and then use named 
arguments to call that method... that's rather confusing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to