Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/20010#discussion_r158844322 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercionSuite.scala --- @@ -389,6 +389,25 @@ class TypeCoercionSuite extends AnalysisTest { widenTest(StringType, MapType(IntegerType, StringType, true), None) widenTest(ArrayType(IntegerType), StructType(Seq()), None) + widenTest( + ArrayType(StringType, containsNull=true), + ArrayType(StringType, containsNull=false), + Some(ArrayType(StringType, containsNull=true))) + widenTest( + MapType(StringType, StringType, valueContainsNull=true), + MapType(StringType, StringType, valueContainsNull=false), + Some(MapType(StringType, StringType, valueContainsNull=true))) --- End diff -- please add a test also for struct
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org