Github user mccheah commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2828#discussion_r18986188
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/worker/Worker.scala 
---
    @@ -362,9 +372,19 @@ private[spark] class Worker(
         }
       }
     
    -  def masterDisconnected() {
    +  private def masterDisconnected() {
         logError("Connection to master failed! Waiting for master to 
reconnect...")
         connected = false
    +    scheduleAttemptsToReconnectToMaster()
    +  }
    +
    +  private def scheduleAttemptsToReconnectToMaster() {
    --- End diff --
    
    In that case we can't directly use registrationRetryTimer, as that 
explicitly kills the worker after a certain number of retries.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to