Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r158893226
--- Diff:
sql/core/src/test/resources/sql-tests/inputs/typeCoercion/native/concat.sql ---
@@ -0,0 +1,93 @@
+-- Concatenate mixed inputs (output type is string)
+SELECT (col1 || col2 || col3) col
+FROM (
+ SELECT
+ id col1,
+ string(id + 1) col2,
+ encode(string(id + 2), 'utf-8') col3
+ FROM range(10)
+);
+
+SELECT ((col1 || col2) || (col3 || col4) || col5) col
+FROM (
+ SELECT
+ 'prefix_' col1,
+ id col2,
+ string(id + 1) col3,
+ encode(string(id + 2), 'utf-8') col4,
+ CAST(id AS DOUBLE) col5
+ FROM range(10)
+);
+
+SELECT ((col1 || col2) || (col3 || col4)) col
--- End diff --
are these 3 cases testing the default value of
`spark.sql.function.concatBinaryAsString`?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
