Github user WeichenXu123 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20058#discussion_r158932419
  
    --- Diff: python/pyspark/ml/base.py ---
    @@ -18,13 +18,40 @@
     from abc import ABCMeta, abstractmethod
     
     import copy
    +import threading
     
     from pyspark import since
    -from pyspark.ml.param import Params
     from pyspark.ml.param.shared import *
     from pyspark.ml.common import inherit_doc
     from pyspark.sql.functions import udf
    -from pyspark.sql.types import StructField, StructType, DoubleType
    +from pyspark.sql.types import StructField, StructType
    +
    +
    +class FitMutlipleIterator(object):
    --- End diff --
    
    What about change this `FitMutlipleIterator` class to be an inner class in 
default implementation method `fitMultiple` ? I think put it outside will be no 
other usage.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to