Github user icexelloss commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19872#discussion_r158952133
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
    @@ -273,7 +274,7 @@ abstract class SparkStrategies extends 
QueryPlanner[SparkPlan] {
     
             aggregate.AggUtils.planStreamingAggregation(
               namedGroupingExpressions,
    -          aggregateExpressions,
    +          aggregateExpressions.map(expr => 
expr.asInstanceOf[AggregateExpression]),
    --- End diff --
    
    Yeah streaming aggregation won't work. Good point. Let me add the check.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to