Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/20111#discussion_r159022677
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/ChiSqSelectorSuite.scala ---
@@ -163,18 +162,19 @@ class ChiSqSelectorSuite extends SparkFunSuite with
MLlibTestSparkContext
assert(expected.selectedFeatures === actual.selectedFeatures)
}
}
-}
-object ChiSqSelectorSuite {
-
- private def testSelector(selector: ChiSqSelector, dataset: Dataset[_]):
ChiSqSelectorModel = {
- val selectorModel = selector.fit(dataset)
- selectorModel.transform(dataset).select("filtered",
"topFeature").collect()
- .foreach { case Row(vec1: Vector, vec2: Vector) =>
+ private def testSelector(selector: ChiSqSelector, data: Dataset[_]):
ChiSqSelectorModel = {
--- End diff --
Moved from object to class b/c this needed testTransformer from the MLTest
mix-in
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
