Github user uzadude commented on a diff in the pull request:
https://github.com/apache/spark/pull/19683#discussion_r159033662
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/GenerateExec.scala ---
@@ -85,11 +84,19 @@ case class GenerateExec(
val numOutputRows = longMetric("numOutputRows")
child.execute().mapPartitionsWithIndexInternal { (index, iter) =>
val generatorNullRow = new
GenericInternalRow(generator.elementSchema.length)
- val rows = if (join) {
+ val rows = if (requiredChildOutput.nonEmpty) {
+
+ val pruneChildForResult: InternalRow => InternalRow =
+ if ((child.outputSet -- requiredChildOutput).isEmpty) {
--- End diff --
wouldn't it always return false? or should I use `child.output ==
AttributeSet(requiredChildOutput)`
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
