Github user Ngone51 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20039#discussion_r159076507
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/LiveListenerBus.scala ---
    @@ -149,7 +158,11 @@ private[spark] class LiveListenerBus(conf: SparkConf) {
         }
     
         this.sparkContext = sc
    -    queues.asScala.foreach(_.start(sc))
    +    queues.asScala.foreach { q =>
    +      q.start(sc)
    +      queuedEvents.foreach(q.post)
    --- End diff --
    
    LiveListener's stop() is not synchronized completely. And LiveListener's 
`stopped` variable could be set "true" in stop() (before the synchronize body) 
while start() is calling. Do I missing something?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to